From 4dc12177c515e63036ebf87b87ff2ebcf2b65bc0 Mon Sep 17 00:00:00 2001 From: Jennifer Sutton Date: Thu, 9 Oct 2025 17:09:40 +1300 Subject: [PATCH] =?utf8?q?s4:kdc:=20Don=E2=80=99t=20leak=20pub=5Fkeys.keys?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jennifer Sutton Reviewed-by: Gary Lockyer --- source4/kdc/db-glue.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c index 80915f2c99c..6bdce0f3363 100644 --- a/source4/kdc/db-glue.c +++ b/source4/kdc/db-glue.c @@ -1880,14 +1880,16 @@ static krb5_error_code get_key_trust_public_keys(TALLOC_CTX *mem_ctx, goto pub_keys_oom; } } else { - pub_keys.keys = realloc_p(pub_keys.keys, - struct sdb_pub_key, - pub_keys.len + 1); - if (pub_keys.keys == NULL) { + struct sdb_pub_key *keys = realloc_p( + pub_keys.keys, + struct sdb_pub_key, + pub_keys.len + 1); + if (keys == NULL) { SAFE_FREE(pub_key.exponent.data); SAFE_FREE(pub_key.modulus.data); goto pub_keys_oom; } + pub_keys.keys = keys; } pub_keys.keys[pub_keys.len] = pub_key; pub_keys.len++; -- 2.47.3