From 4e3a9daa6668051f1d8669e989ae7594c4e22619 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Wed, 6 Jun 2018 20:21:26 -0400 Subject: [PATCH] qemu: Allow no address to be defined for virtio-scsi iothread attach MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit https://bugzilla.redhat.com/show_bug.cgi?id=1583623 When attaching a virtio-scsi with IOThreads for the config of a live domain, allow the
to not be defined thus allowing post parse processing to fill in the address. This allows parsing of an individual device to succeed for attach config. Signed-off-by: John Ferlan Reviewed-by: Ján Tomko --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cd8870ae1f..ac37fe1212 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4781,7 +4781,8 @@ qemuDomainCheckSCSIControllerIOThreads(const virDomainControllerDef *controller, if (!controller->iothread) return true; - if (controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && + if (controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && + controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && controller->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("virtio-scsi IOThreads only available for virtio " -- 2.47.2