From 4e9bfdaad296e1a5131fead21862dba4e674e95b Mon Sep 17 00:00:00 2001 From: James Jones Date: Tue, 30 May 2023 15:06:07 -0500 Subject: [PATCH] Pull check for non-NULL randle after check for NULL randle randle is local to mod_authenticate(), so in the then clause of an if checking for randle being NULL, randle won't be non-NULL. --- src/modules/rlm_imap/rlm_imap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/modules/rlm_imap/rlm_imap.c b/src/modules/rlm_imap/rlm_imap.c index 93b4c4a4201..23c28918d6c 100644 --- a/src/modules/rlm_imap/rlm_imap.c +++ b/src/modules/rlm_imap/rlm_imap.c @@ -177,7 +177,6 @@ static unlang_action_t CC_HINT(nonnull(1,2)) mod_authenticate(rlm_rcode_t *p_res randle = imap_slab_reserve(t->slab); if (!randle){ - if (randle) imap_slab_release(randle); RETURN_MODULE_FAIL; } -- 2.47.3