From 4f7b5b9bcd130892e0321f9854bf0404ac2e4225 Mon Sep 17 00:00:00 2001 From: Kamalesh Babulal Date: Wed, 10 Aug 2022 11:13:19 -0600 Subject: [PATCH] daemon/cgrulesengd: check the bytes read in cgre_receive_unix_domain_msg() Fix ignoring the number of bytes read, warning reported by Coverity tool: CID 258286 (#1 of 1): Ignoring number of bytes read (CHECKED_RETURN). check_return: read(int, void *, size_t) returns the number of bytes read, but it is ignored. In cgre_receive_unix_domain_msg(), the number of bytes read() is ignored, while reading from the flag value of the pid. Coverity warns on not checking the number of bytes read, fix it. Signed-off-by: Kamalesh Babulal Signed-off-by: Tom Hromatka (cherry picked from commit ed283eab173addd3b5c2dd666de8f3086125e106) --- src/daemon/cgrulesengd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c index 7c514122..51988de5 100644 --- a/src/daemon/cgrulesengd.c +++ b/src/daemon/cgrulesengd.c @@ -619,7 +619,8 @@ static void cgre_receive_unix_domain_msg(int sk_unix) return; } - if (read(fd_client, &pid, sizeof(pid)) < 0) { + ret_len = read(fd_client, &pid, sizeof(pid)); + if (ret_len != sizeof(pid)) { flog(LOG_WARNING, "Warning: 'read' command error: %s\n", strerror(errno)); goto close; } -- 2.47.2