From 52dd95fb5cb1aa0e1b00bdcfc3f8c1cbbdcf10b5 Mon Sep 17 00:00:00 2001 From: Jonas Lundberg Date: Thu, 1 Apr 2021 16:32:20 +0200 Subject: [PATCH] Fix extenstions typo in AsyncHTTPTransport (#1549) --- httpx/_transports/default.py | 2 +- tests/client/test_async_client.py | 9 +++++++++ tests/client/test_client.py | 8 ++++++++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/httpx/_transports/default.py b/httpx/_transports/default.py index 67f62322..5691538d 100644 --- a/httpx/_transports/default.py +++ b/httpx/_transports/default.py @@ -264,7 +264,7 @@ class AsyncHTTPTransport(AsyncBaseTransport): int, typing.List[typing.Tuple[bytes, bytes]], typing.AsyncIterable[bytes], dict ]: with map_httpcore_exceptions(): - status_code, headers, byte_stream, extenstions = await self._pool.arequest( + status_code, headers, byte_stream, extensions = await self._pool.arequest( method=method, url=url, headers=headers, diff --git a/tests/client/test_async_client.py b/tests/client/test_async_client.py index 99493c43..6c121b5e 100644 --- a/tests/client/test_async_client.py +++ b/tests/client/test_async_client.py @@ -313,3 +313,12 @@ async def test_async_mock_transport(): response = await client.get("https://www.example.com") assert response.status_code == 200 assert response.text == "Hello, world!" + + +@pytest.mark.usefixtures("async_environment") +async def test_server_extensions(server): + url = server.url + async with httpx.AsyncClient(http2=True) as client: + response = await client.get(url) + assert response.status_code == 200 + assert response.extensions["http_version"] == b"HTTP/1.1" diff --git a/tests/client/test_client.py b/tests/client/test_client.py index 386cd748..0538e960 100644 --- a/tests/client/test_client.py +++ b/tests/client/test_client.py @@ -383,3 +383,11 @@ def test_all_mounted_transport(): response = client.get("https://www.example.com") assert response.status_code == 200 assert response.json() == {"app": "mounted"} + + +def test_server_extensions(server): + url = server.url.copy_with(path="/http_version_2") + with httpx.Client(http2=True) as client: + response = client.get(url) + assert response.status_code == 200 + assert response.extensions["http_version"] == b"HTTP/1.1" -- 2.47.3