From 5560bad6953b7d1b5b4730e6eef66ab79e321d46 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Wed, 19 Nov 2025 09:26:30 +0100 Subject: [PATCH] tests/functional/ppc/test_amiga: Fix issues reported by pylint and flake8 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Pylint complains about unused variable "tar_name" and a missing "check" for subprocess.run(), and flake8 suggest a second empty line after the class. While we're at it, also remove the unused "timeout" class variable (that was only necessary for the avocado framework which we don't use anymore). Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth Message-ID: <20251119082636.43286-10-thuth@redhat.com> --- tests/functional/ppc/test_amiga.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/functional/ppc/test_amiga.py b/tests/functional/ppc/test_amiga.py index 8600e2e963..36378fb697 100755 --- a/tests/functional/ppc/test_amiga.py +++ b/tests/functional/ppc/test_amiga.py @@ -15,8 +15,6 @@ from qemu_test import wait_for_console_pattern class AmigaOneMachine(QemuSystemTest): - timeout = 90 - ASSET_IMAGE = Asset( ('https://www.hyperion-entertainment.com/index.php/' 'downloads?view=download&format=raw&file=25'), @@ -25,19 +23,19 @@ class AmigaOneMachine(QemuSystemTest): def test_ppc_amigaone(self): self.require_accelerator("tcg") self.set_machine('amigaone') - tar_name = 'A1Firmware_Floppy_05-Mar-2005.zip' self.archive_extract(self.ASSET_IMAGE, format="zip") bios = self.scratch_file("u-boot-amigaone.bin") with open(bios, "wb") as bios_fh: subprocess.run(['tail', '-c', '524288', self.scratch_file("floppy_edition", "updater.image")], - stdout=bios_fh) + stdout=bios_fh, check=True) self.vm.set_console() self.vm.add_args('-bios', bios) self.vm.launch() wait_for_console_pattern(self, 'FLASH:') + if __name__ == '__main__': QemuSystemTest.main() -- 2.47.3