From 56737483c2ffdaadfec648fd38d409c6b10941c0 Mon Sep 17 00:00:00 2001
From: Armaan Vakharia <43391096+armaan-v924@users.noreply.github.com>
Date: Mon, 18 May 2026 16:00:59 -0700
Subject: [PATCH] gh-149590: Remove faulthandler_traverse (#150023)

`faulthandler_traverse` visits Python objects owned by `_PyRuntime`, not
by the module instance. With multi-phase init allowing multiple module
instances, each instance's GC traversal decrements `gc_refs` on the same
runtime-owned objects, driving it negative when two instances are
collected simultaneously.
---
 ...026-05-18-13-47-17.gh-issue-149590.IPBeQx.rst |  1 +
 Modules/faulthandler.c                           | 16 ----------------
 2 files changed, 1 insertion(+), 16 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Core_and_Builtins/2026-05-18-13-47-17.gh-issue-149590.IPBeQx.rst

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-05-18-13-47-17.gh-issue-149590.IPBeQx.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-05-18-13-47-17.gh-issue-149590.IPBeQx.rst
new file mode 100644
index 000000000000..8d3b29d69cc8
--- /dev/null
+++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-05-18-13-47-17.gh-issue-149590.IPBeQx.rst
@@ -0,0 +1 @@
+Fix crash when faulthandler is imported more than once.
diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c
index 1b4f0c2302da..fa7fb7085d7e 100644
--- a/Modules/faulthandler.c
+++ b/Modules/faulthandler.c
@@ -1349,21 +1349,6 @@ faulthandler__stack_overflow_impl(PyObject *module)
 #endif   /* defined(FAULTHANDLER_USE_ALT_STACK) && defined(HAVE_SIGACTION) */
 
 
-static int
-faulthandler_traverse(PyObject *module, visitproc visit, void *arg)
-{
-    Py_VISIT(thread.file);
-#ifdef FAULTHANDLER_USER
-    if (user_signals != NULL) {
-        for (size_t signum=0; signum < Py_NSIG; signum++)
-            Py_VISIT(user_signals[signum].file);
-    }
-#endif
-    Py_VISIT(fatal_error.file);
-    return 0;
-}
-
-
 #ifdef MS_WINDOWS
 /*[clinic input]
 faulthandler._raise_exception
@@ -1459,7 +1444,6 @@ static struct PyModuleDef module_def = {
     .m_name = "faulthandler",
     .m_doc = module_doc,
     .m_methods = module_methods,
-    .m_traverse = faulthandler_traverse,
     .m_slots = faulthandler_slots
 };
 
-- 
2.47.3