From 5684fb080528abbcb10a2e1c9aaceea13af5cecc Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Wed, 29 Oct 2025 09:15:14 +0100 Subject: [PATCH] tests/functional/x86_64/test_acpi_bits: Silence warnings reported by pylint Pylint complains about too many positional arguments for the __init__ function of the QEMUBitsMachine class, use a "*" to enforce argument passing by names instead (which the calling sites are doing here already). Second, use lazy logging when calling self.log.info() with a "%s" format string, and drop a superfluous "else:" that is not necessary after a "raise" statement. Reviewed-by: Zhao Liu Signed-off-by: Thomas Huth Message-ID: <20251029081514.60802-1-thuth@redhat.com> --- tests/functional/x86_64/test_acpi_bits.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/x86_64/test_acpi_bits.py b/tests/functional/x86_64/test_acpi_bits.py index 9a2816533d..ec716d643b 100755 --- a/tests/functional/x86_64/test_acpi_bits.py +++ b/tests/functional/x86_64/test_acpi_bits.py @@ -57,6 +57,7 @@ class QEMUBitsMachine(QEMUMachine): # pylint: disable=too-few-public-methods """ def __init__(self, binary: str, + *, args: Sequence[str] = (), wrapper: Sequence[str] = (), name: Optional[str] = None, @@ -225,7 +226,7 @@ class AcpiBitsTest(QemuSystemTest): #pylint: disable=too-many-instance-attribute stdout=subprocess.PIPE, stderr=subprocess.STDOUT, check=True) - self.log.info("grub-mkrescue output %s" % proc.stdout) + self.log.info("grub-mkrescue output %s", proc.stdout) else: subprocess.check_call([mkrescue_script, '-o', iso_file, bits_dir], @@ -287,9 +288,8 @@ class AcpiBitsTest(QemuSystemTest): #pylint: disable=too-many-instance-attribute except AssertionError as e: self._print_log(log) raise e - else: - if os.getenv('V') or os.getenv('BITS_DEBUG'): - self._print_log(log) + if os.getenv('V') or os.getenv('BITS_DEBUG'): + self._print_log(log) def tearDown(self): """ -- 2.47.3