From 5761b5f169933fab63a4ec6ba2eecef88d84fd34 Mon Sep 17 00:00:00 2001 From: Ben Kaduk Date: Fri, 6 Mar 2015 15:42:10 -0500 Subject: [PATCH] Fix loop to determine MSLSA principal name When looping over principals, check the i-th entry instead of looking at the 0-th entry each time through the loop. This would only affect cases when multiple ticket entries were returned from the LSA, the first one did not have a valid principal name, but some other one did. It is expected that all of the returned ticket entries will always have a valid client principal name, so this is unlikely to cause any functional difference. (cherry picked from commit d7dc6c347e352324e374b3456f60e49aa4b8ba08) ticket: 8177 version_fixed: 1.13.3 status: resolved --- src/lib/krb5/ccache/cc_mslsa.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/krb5/ccache/cc_mslsa.c b/src/lib/krb5/ccache/cc_mslsa.c index c775805420..7a80470237 100644 --- a/src/lib/krb5/ccache/cc_mslsa.c +++ b/src/lib/krb5/ccache/cc_mslsa.c @@ -1568,8 +1568,8 @@ krb5_lcc_resolve (krb5_context context, krb5_ccache *id, const char *residual) /* Take the first client principal we find; they should all be the * same anyway. */ for (i = 0; i < pResponse->CountOfTickets; i++) { - if (UnicodeStringToMITPrinc(&pResponse->Tickets[0].ClientName, - &pResponse->Tickets[0].ClientRealm, + if (UnicodeStringToMITPrinc(&pResponse->Tickets[i].ClientName, + &pResponse->Tickets[i].ClientRealm, context, &data->princ)) break; @@ -1915,8 +1915,8 @@ krb5_lcc_get_principal(krb5_context context, krb5_ccache id, krb5_principal *pri /* Take the first client principal we find; they should all be the * same anyway. */ for (i = 0; i < pResponse->CountOfTickets; i++) { - if (UnicodeStringToMITPrinc(&pResponse->Tickets[0].ClientName, - &pResponse->Tickets[0].ClientRealm, + if (UnicodeStringToMITPrinc(&pResponse->Tickets[i].ClientName, + &pResponse->Tickets[i].ClientRealm, context, &data->princ)) break; } -- 2.47.2