From 579f02351b09cc5870dc5e31acf0c88caea6dd62 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Thu, 5 Mar 2020 15:41:49 +0000 Subject: [PATCH] test: fix leak of authentication info MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The 'auths' struct in the test driver was not free()d. This was easy to miss because the default XML doesn't include auth info. Reviewed-by: Daniel Henrique Barboza Signed-off-by: Daniel P. Berrangé --- src/test/test_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 029d560fb9..73fe1ad6ce 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -156,6 +156,7 @@ static void testDriverDispose(void *obj) { testDriverPtr driver = obj; + size_t i; virObjectUnref(driver->caps); virObjectUnref(driver->xmlopt); @@ -165,6 +166,11 @@ testDriverDispose(void *obj) virObjectUnref(driver->ifaces); virObjectUnref(driver->pools); virObjectUnref(driver->eventState); + for (i = 0; i < driver->numAuths; i++) { + g_free(driver->auths[i].username); + g_free(driver->auths[i].password); + } + g_free(driver->auths); } typedef struct _testDomainNamespaceDef testDomainNamespaceDef; -- 2.47.2