From 57d58836cd3b63e6f8b49b08c2ad66189c2c417f Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Wed, 15 Oct 2025 10:53:40 +0300 Subject: [PATCH] media: renesas: fdp1: Drop unneeded v4l2_m2m_get_vq() NULL check The v4l2_m2m_get_vq() function never returns NULL. The check was probably intended to catch invalid format types, but that's not needed as the V4L2 core picks the appropriate VIDIOC_G_FMT ioctl handler based on the format type, so the type can't be incorrect. Drop the unneeded return value check and, as the function has no side effect, the function call as well. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Signed-off-by: Hans Verkuil --- drivers/media/platform/renesas/rcar_fdp1.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c index e615c56083f13..3515601030ecc 100644 --- a/drivers/media/platform/renesas/rcar_fdp1.c +++ b/drivers/media/platform/renesas/rcar_fdp1.c @@ -1409,9 +1409,6 @@ static int fdp1_g_fmt(struct file *file, void *priv, struct v4l2_format *f) struct fdp1_ctx *ctx = file_to_ctx(file); struct fdp1_q_data *q_data; - if (!v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type)) - return -EINVAL; - q_data = get_q_data(ctx, f->type); f->fmt.pix_mp = q_data->format; -- 2.47.3