From 5807689f96889e1ce886d253bf2e4c478c554ce2 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Sat, 11 May 2024 02:38:21 +0200 Subject: [PATCH] s3:utils: let net_update_dns_internal() set status before goto done in all cases Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider --- source3/utils/net_ads_join_dns.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source3/utils/net_ads_join_dns.c b/source3/utils/net_ads_join_dns.c index 3437f96ee58..97f767aba66 100644 --- a/source3/utils/net_ads_join_dns.c +++ b/source3/utils/net_ads_join_dns.c @@ -88,6 +88,7 @@ static NTSTATUS net_update_dns_internal(struct net_context *c, ads_status = ads_connect( ads ); if ( !ADS_ERR_OK(ads_status) ) { DEBUG(0,("net_update_dns_internal: Failed to connect to our DC!\n")); + status = ads_ntstatus(ads_status); goto done; } } @@ -95,12 +96,14 @@ static NTSTATUS net_update_dns_internal(struct net_context *c, ads_status = ads_do_search(ads, "", LDAP_SCOPE_BASE, "(objectclass=*)", rootname_attrs, &msg); if (!ADS_ERR_OK(ads_status)) { + status = ads_ntstatus(ads_status); goto done; } root_dn = ads_pull_string(ads, ctx, msg, "rootDomainNamingContext"); if ( !root_dn ) { ads_msgfree( ads, msg ); + status = NT_STATUS_INVALID_NETWORK_RESPONSE; goto done; } -- 2.47.3