From 5893de54d8fbfcf17437c3560eb7cb89b23e5c0e Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Mon, 10 Apr 2017 17:32:04 -0500 Subject: [PATCH] xfsprogs: fix build dep on configure.ac Zorro reported that this sequence: # git checkout v4.9.0; make realclean; make # git checkout v4.10.0; make clean; make fails: ... Building libxfs [CC] gen_crc32table gcc: error: @BUILD_CFLAGS@: No such file or directory gmake[3]: *** No rule to make target `crc32table.h', needed by `crc32selftest'. Stop. This is because 0a71e38 build: Allow compiling xfsprogs in a cross compile environment added the new BUILD_CFLAGS to configure.ac, and unless we re-run autotools, that variable does not get substituted when include/builddefs gets built. (This can be worked around by "make realclean" and then everything gets regenerated.) The configure script is generated from configure.ac, so adding a Make dependency here should resolve such issues in the future. Reported-by: Zorro Lang Signed-off-by: Eric Sandeen Reviewed-by: Christoph Hellwig Signed-off-by: Eric Sandeen --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6e45733ee..ba87327d8 100644 --- a/Makefile +++ b/Makefile @@ -101,7 +101,7 @@ endif # versions will copy those files anyway, and don't understand -i. LIBTOOLIZE_INSTALL = `$(LIBTOOLIZE_BIN) -n -i >/dev/null 2>/dev/null && echo -i` -configure: +configure: configure.ac $(LIBTOOLIZE_BIN) -c $(LIBTOOLIZE_INSTALL) -f cp include/install-sh . aclocal -I m4 -- 2.47.2