From 58eaf85bd924f4f9264d677486c0122a5a2c9f9f Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 5 Nov 2020 15:48:08 -0800 Subject: [PATCH] s3: spoolss: Make parameters in call to user_ok_token() match all other uses. We already have p->session_info->unix_info->unix_name, we don't need to go through a legacy call to uidtoname(p->session_info->unix_token->uid). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14568 Signed-off-by: Jeremy Allison Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Mon Nov 9 04:10:45 UTC 2020 on sn-devel-184 (cherry picked from commit e5e1759057a767f517bf480a2172a36623df2799) --- source3/rpc_server/spoolss/srv_spoolss_nt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index c80fc2aac2d..eb47cb20581 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -1871,7 +1871,8 @@ WERROR _spoolss_OpenPrinterEx(struct pipes_struct *p, return WERR_ACCESS_DENIED; } - if (!user_ok_token(uidtoname(p->session_info->unix_token->uid), NULL, + if (!user_ok_token(p->session_info->unix_info->unix_name, + p->session_info->info->domain_name, p->session_info->security_token, snum) || !W_ERROR_IS_OK(print_access_check(p->session_info, p->msg_ctx, -- 2.47.2