From 5918af6abb991e6d2322ea4252e56d456da628dc Mon Sep 17 00:00:00 2001 From: Rafi Shamim Date: Tue, 23 Jun 2020 14:20:54 -0400 Subject: [PATCH] Improvements to test_computed_col_default_not_set - Update the test so it looks at computed_default_table instead of computed_column_table. - Stop inspecting autoincrement; instead directly check for default/non-default values for the relevant columns. Fixes: #5414 --- lib/sqlalchemy/testing/suite/test_reflection.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/sqlalchemy/testing/suite/test_reflection.py b/lib/sqlalchemy/testing/suite/test_reflection.py index 7080888813..84b3aba5be 100644 --- a/lib/sqlalchemy/testing/suite/test_reflection.py +++ b/lib/sqlalchemy/testing/suite/test_reflection.py @@ -1171,12 +1171,11 @@ class ComputedReflectionTest(fixtures.ComputedReflectionFixtureTest): def test_computed_col_default_not_set(self): insp = inspect(config.db) - cols = insp.get_columns("computed_column_table") - for col in cols: - if col["name"] == "with_default": - is_true("42" in col["default"]) - elif not col["autoincrement"]: - is_(col["default"], None) + cols = insp.get_columns("computed_default_table") + col_data = {c["name"]: c for c in cols} + is_true("42" in col_data["with_default"]["default"]) + is_(col_data["normal"]["default"], None) + is_(col_data["computed_col"]["default"], None) def test_get_column_returns_computed(self): insp = inspect(config.db) -- 2.47.3