From 5932e8649d051d2186cd06fb67f3249a11e57638 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 2 May 2008 01:15:26 +0000 Subject: [PATCH] - an unfortunate naming conflict - needed sql import on and() --- lib/sqlalchemy/exceptions.py | 2 +- lib/sqlalchemy/schema.py | 2 +- lib/sqlalchemy/sql/util.py | 6 +++--- test/sql/selectable.py | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/sqlalchemy/exceptions.py b/lib/sqlalchemy/exceptions.py index 747a519f65..43623df93f 100644 --- a/lib/sqlalchemy/exceptions.py +++ b/lib/sqlalchemy/exceptions.py @@ -65,7 +65,7 @@ class AssertionError(SQLAlchemyError): class NoSuchColumnError(KeyError, SQLAlchemyError): """Raised by ``RowProxy`` when a nonexistent column is requested from a row.""" -class NoSuchTableError(InvalidRequestError): +class NoReferencedTableError(InvalidRequestError): """Raised by ``ForeignKey`` when the referred ``Table`` cannot be located.""" class DisconnectionError(SQLAlchemyError): diff --git a/lib/sqlalchemy/schema.py b/lib/sqlalchemy/schema.py index 5ca9573adb..66d1a17366 100644 --- a/lib/sqlalchemy/schema.py +++ b/lib/sqlalchemy/schema.py @@ -782,7 +782,7 @@ class ForeignKey(SchemaItem): else: (schema,tname,colname) = m.group(1,2,3) if _get_table_key(tname, schema) not in parenttable.metadata: - raise exceptions.NoSuchTableError( + raise exceptions.NoReferencedTableError( "Could not find table '%s' with which to generate a " "foreign key" % tname) table = Table(tname, parenttable.metadata, diff --git a/lib/sqlalchemy/sql/util.py b/lib/sqlalchemy/sql/util.py index 0c85cbe4a8..d299982cfa 100644 --- a/lib/sqlalchemy/sql/util.py +++ b/lib/sqlalchemy/sql/util.py @@ -72,7 +72,7 @@ def join_condition(a, b, ignore_nonexistent_tables=False): for fk in b.foreign_keys: try: col = fk.get_referent(a) - except exceptions.NoSuchTableError: + except exceptions.NoReferencedTableError: if ignore_nonexistent_tables: continue else: @@ -86,7 +86,7 @@ def join_condition(a, b, ignore_nonexistent_tables=False): for fk in a.foreign_keys: try: col = fk.get_referent(b) - except exceptions.NoSuchTableError: + except exceptions.NoReferencedTableError: if ignore_nonexistent_tables: continue else: @@ -110,7 +110,7 @@ def join_condition(a, b, ignore_nonexistent_tables=False): elif len(crit) == 1: return (crit[0]) else: - return and_(*crit) + return sql.and_(*crit) def reduce_columns(columns, *clauses): diff --git a/test/sql/selectable.py b/test/sql/selectable.py index 20788fedc8..d3b6397674 100755 --- a/test/sql/selectable.py +++ b/test/sql/selectable.py @@ -233,7 +233,7 @@ class SelectableTest(TestBase, AssertsExecutionResults): s = select([t2, t3], use_labels=True) - self.assertRaises(exceptions.NoSuchTableError, s.join, t1) + self.assertRaises(exceptions.NoReferencedTableError, s.join, t1) class PrimaryKeyTest(TestBase, AssertsExecutionResults): def test_join_pk_collapse_implicit(self): -- 2.47.3