From 59f922a134897c340db87b18efd6255fabbdaa28 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Mon, 15 Apr 2024 12:29:12 +0200 Subject: [PATCH] decode/ppp: add missing types definitions Recognize PPP_CCP, PPP_CBCP and PPP_COMP_DGRAM. Does not implement decoders for these record types, so these are logged as unsupported types. Was "wrong_type" before. (cherry picked from commit 516441b6005f4200ae155f5234cfd0ad20d2dfbc) --- src/decode-ppp.c | 3 +++ src/decode-ppp.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/decode-ppp.c b/src/decode-ppp.c index 2e558ab5bf..1d22b25589 100644 --- a/src/decode-ppp.c +++ b/src/decode-ppp.c @@ -158,6 +158,9 @@ static int DecodePPPUncompressedProto(ThreadVars *tv, DecodeThreadVars *dtv, Pac case PPP_PAP: case PPP_LQM: case PPP_CHAP: + case PPP_CCP: + case PPP_CBCP: + case PPP_COMP_DGRAM: ENGINE_SET_EVENT(p,PPP_UNSUP_PROTO); return TM_ECODE_OK; diff --git a/src/decode-ppp.h b/src/decode-ppp.h index f8914cf2e7..66894b03d7 100644 --- a/src/decode-ppp.h +++ b/src/decode-ppp.h @@ -59,6 +59,9 @@ #define PPP_PAP 0xc023 /* Password Authentication Protocol */ #define PPP_LQM 0xc025 /* Link Quality Monitoring */ #define PPP_CHAP 0xc223 /* Challenge Handshake Authentication Protocol */ +#define PPP_CCP 0x80fd /* Compression Control Protocol */ +#define PPP_CBCP 0xc029 /* Callback Control Protocol CBCP */ +#define PPP_COMP_DGRAM 0x00fd /* Compressed datagram */ /** PPP Packet header */ typedef struct PPPHdr_ { -- 2.47.2