From 5a8e40890ed578b998b53bb4858c420e3ac14a02 Mon Sep 17 00:00:00 2001 From: Razvan Becheriu Date: Mon, 27 Jul 2020 19:37:57 +0300 Subject: [PATCH] [#1065] addressed review --- src/hooks/dhcp/lease_cmds/lease_cmds.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/hooks/dhcp/lease_cmds/lease_cmds.cc b/src/hooks/dhcp/lease_cmds/lease_cmds.cc index ee8d1c5754..cfc6323432 100644 --- a/src/hooks/dhcp/lease_cmds/lease_cmds.cc +++ b/src/hooks/dhcp/lease_cmds/lease_cmds.cc @@ -452,7 +452,7 @@ LeaseCmdsImpl::updateStatsOnUpdate(const Lease4Ptr& existing, "assigned-addresses"), int64_t(-1)); } - if (existing->stateDeclined() && !lease->stateDeclined()) { + if (existing->stateDeclined()) { // old lease is declined StatsMgr::instance().addValue("declined-addresses", int64_t(-1)); @@ -469,7 +469,7 @@ LeaseCmdsImpl::updateStatsOnUpdate(const Lease4Ptr& existing, "assigned-addresses"), int64_t(1)); } - if (lease->stateDeclined() && !existing->stateDeclined()) { + if (lease->stateDeclined()) { // new lease is declined StatsMgr::instance().addValue("declined-addresses", int64_t(1)); @@ -514,7 +514,7 @@ LeaseCmdsImpl::updateStatsOnUpdate(const Lease6Ptr& existing, } // @node current code does not check for declined PD // code must be updated in parser (see @todo in lease_parser.cc) - if (existing->stateDeclined() && !lease->stateDeclined()) { + if (existing->stateDeclined()) { // old lease is declined StatsMgr::instance().addValue("declined-addresses", int64_t(-1)); @@ -534,7 +534,7 @@ LeaseCmdsImpl::updateStatsOnUpdate(const Lease6Ptr& existing, } // @node current code does not check for declined PD // code must be updated in parser (see @todo in lease_parser.cc) - if (lease->stateDeclined() && !existing->stateDeclined()) { + if (lease->stateDeclined()) { // new lease is declined StatsMgr::instance().addValue("declined-addresses", int64_t(1)); -- 2.47.2