From 5abf5949c18bfc3b49fad2eadf21e6bc359822aa Mon Sep 17 00:00:00 2001 From: William Douglas Date: Fri, 1 Oct 2021 11:12:33 -0700 Subject: [PATCH] ch_monitor: Stop leaking json value objects In virCHMonitorBuildKernelRelatedJson there are two cases of json value objects being lost after the pointer being redefined. This change removes the needless redefinition. Signed-off-by: William Douglas Reviewed-by: Laine Stump --- src/ch/ch_monitor.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 5ed26a574f..a1430f0e65 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@ -121,7 +121,6 @@ virCHMonitorBuildKernelRelatedJson(virJSONValue *content, virDomainDef *vmdef) _("Kernel image path in this domain is not defined")); goto cleanup; } else { - kernel = virJSONValueNewObject(); if (virJSONValueObjectAppendString(kernel, "path", vmdef->os.kernel) < 0) goto cleanup; if (virJSONValueObjectAppend(content, "kernel", &kernel) < 0) @@ -136,7 +135,6 @@ virCHMonitorBuildKernelRelatedJson(virJSONValue *content, virDomainDef *vmdef) } if (vmdef->os.initrd != NULL) { - initramfs = virJSONValueNewObject(); if (virJSONValueObjectAppendString(initramfs, "path", vmdef->os.initrd) < 0) goto cleanup; if (virJSONValueObjectAppend(content, "initramfs", &initramfs) < 0) -- 2.47.2