From 5acb4eede23bcd5bc75193ea21542e0fb04b6e45 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Fri, 21 Jun 2019 13:07:15 -0400 Subject: [PATCH] cpu_x86: Fix memory leak - virCPUx86GetHost Commit 56b254dcc called virCPUx86DataAdd, but returned -1 directly without calling the virCPUx86DataFree. Found by Coverity. Signed-off-by: John Ferlan Reviewed-by: Michal Privoznik --- src/cpu/cpu_x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 71fc365139..978a60c90a 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2791,7 +2791,7 @@ virCPUx86GetHost(virCPUDefPtr cpu, }; if (virCPUx86DataAdd(cpuData, &item) < 0) - return -1; + goto cleanup; } } -- 2.47.2