From 5b7f1e9d566c8a0a148848811e3120c73cb49830 Mon Sep 17 00:00:00 2001 From: "Alan T. DeKok" Date: Sat, 21 Jun 2025 07:27:21 -0400 Subject: [PATCH] add note that Nonce isn't used --- src/modules/rlm_eap/types/rlm_eap_teap/eap_teap.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/modules/rlm_eap/types/rlm_eap_teap/eap_teap.c b/src/modules/rlm_eap/types/rlm_eap_teap/eap_teap.c index cf4fd82151..b96b7de5ca 100644 --- a/src/modules/rlm_eap/types/rlm_eap_teap/eap_teap.c +++ b/src/modules/rlm_eap/types/rlm_eap_teap/eap_teap.c @@ -300,6 +300,20 @@ static void eap_teap_append_crypto_binding(REQUEST *request, tls_session_t *tls_ RANDFILL(cbb->binding.nonce); cbb->binding.nonce[sizeof(cbb->binding.nonce) - 1] &= ~0x01; /* RFC 7170, Section 4.2.13 */ + /* + * RFC7170bis: + * + * > The Nonce field is 32 octets. It contains a 256-bit nonce that is + * > temporally unique, used for Compound-MAC key derivation at each + * > end. The nonce in a request MUST have its least significant bit + * > set to zero (0), and the nonce in a response MUST have the same + * > value as the request nonce except the least significant bit MUST + * > be set to one (1). + * + * Uh.... it looks like we don't do this? The Nonce + * field is actually not used for anything in RFC7170, either. + */ + outer_tlvs = &cbb->outer_tlvs[0]; if (tls_session->outer_tlvs_octets_server) { -- 2.47.2