From 5c4fc07d1ad9b14afa33b97b20ed6f1329c2c153 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Fri, 15 Sep 2017 16:41:18 +0200 Subject: [PATCH] qemu: Fix error checking in qemuDomainDefFormatXMLInternal virDomainDefFormatInternal (called by qemuDomainDefFormatXMLInternal) already checks for buffer errors and properly resets the buffer on failure. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 94c95140f2..ddc76b1c93 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4728,16 +4728,8 @@ qemuDomainDefFormatXMLInternal(virQEMUDriverPtr driver, { virBuffer buf = VIR_BUFFER_INITIALIZER; - if (qemuDomainDefFormatBufInternal(driver, def, origCPU, flags, &buf) < 0) { - virBufferFreeAndReset(&buf); + if (qemuDomainDefFormatBufInternal(driver, def, origCPU, flags, &buf) < 0) return NULL; - } - - if (virBufferError(&buf)) { - virReportOOMError(); - virBufferFreeAndReset(&buf); - return NULL; - } return virBufferContentAndReset(&buf); } -- 2.47.2