From 5d791718532502ce1ec79aaaaccd2a9b129f73a5 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Fri, 9 Aug 2019 10:30:19 -0700 Subject: [PATCH] s3: VFS: vfs_snapper: Make chflags return errno = EROFS on a shadow copy path. smbd has no business modifying a shadow copy filesystem, it should be read-only. Signed-off-by: Jeremy Allison Reviewed-by: David Disseldorp --- source3/modules/vfs_snapper.c | 35 ++++------------------------------- 1 file changed, 4 insertions(+), 31 deletions(-) diff --git a/source3/modules/vfs_snapper.c b/source3/modules/vfs_snapper.c index c3549d4aad9..28edfd7a4d9 100644 --- a/source3/modules/vfs_snapper.c +++ b/source3/modules/vfs_snapper.c @@ -2551,43 +2551,16 @@ static int snapper_gmt_chflags(vfs_handle_struct *handle, unsigned int flags) { time_t timestamp = 0; - char *stripped = NULL; - int ret = -1; - int saved_errno = 0; - char *conv = NULL; - struct smb_filename *conv_smb_fname = NULL; if (!snapper_gmt_strip_snapshot(talloc_tos(), handle, - smb_fname->base_name, ×tamp, &stripped)) { + smb_fname->base_name, ×tamp, NULL)) { return -1; } - if (timestamp == 0) { - return SMB_VFS_NEXT_CHFLAGS(handle, smb_fname, flags); - } - conv = snapper_gmt_convert(talloc_tos(), handle, stripped, timestamp); - TALLOC_FREE(stripped); - if (conv == NULL) { - return -1; - } - conv_smb_fname = synthetic_smb_fname(talloc_tos(), - conv, - NULL, - NULL, - smb_fname->flags); - TALLOC_FREE(conv); - if (conv_smb_fname == NULL) { - errno = ENOMEM; + if (timestamp != 0) { + errno = EROFS; return -1; } - ret = SMB_VFS_NEXT_CHFLAGS(handle, conv_smb_fname, flags); - if (ret == -1) { - saved_errno = errno; - } - TALLOC_FREE(conv_smb_fname); - if (saved_errno != 0) { - errno = saved_errno; - } - return ret; + return SMB_VFS_NEXT_CHFLAGS(handle, smb_fname, flags); } static ssize_t snapper_gmt_getxattr(vfs_handle_struct *handle, -- 2.47.2