From 5da077c29b4518626d695c6b5edf9d720fbc8779 Mon Sep 17 00:00:00 2001 From: Alexandre Oliva Date: Fri, 14 May 1999 06:50:32 +0000 Subject: [PATCH] * instutil/chmod: New script to avoid chmod'ing files while installing libltdl's sources. * instutil/ln: New script to avoid hard-linking libltdl's sources in the install tree. * Makefile.am (EXTRA_DIST): Dist them. (instal-data-hook): Add srcdir/instutil to the beginning of the PATH before installing libltdl's sources. --- ChangeLog | 10 ++++++++ Makefile.am | 4 ++-- instutil/chmod | 13 ++++++++++ instutil/ln | 14 +++++++++++ mail/security | 65 -------------------------------------------------- 5 files changed, 39 insertions(+), 67 deletions(-) create mode 100755 instutil/chmod create mode 100755 instutil/ln delete mode 100644 mail/security diff --git a/ChangeLog b/ChangeLog index 2395b05cd..231c58707 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +1999-05-14 Alexandre Oliva + + * instutil/chmod: New script to avoid chmod'ing files while + installing libltdl's sources. + * instutil/ln: New script to avoid hard-linking libltdl's sources + in the install tree. + * Makefile.am (EXTRA_DIST): Dist them. + (instal-data-hook): Add srcdir/instutil to the beginning of the + PATH before installing libltdl's sources. + 1999-05-09 Gary V. Vaughan * TODO: updated. diff --git a/Makefile.am b/Makefile.am index 0b7dc1b11..7af058efa 100644 --- a/Makefile.am +++ b/Makefile.am @@ -15,7 +15,7 @@ LIBS= @LIBS@ aclocal_macros = libtool.m4 EXTRA_DIST = $(aclocal_macros) libtoolize.in ltconfig.in ltmain.in \ - mkstamp ChangeLog.0 + mkstamp ChangeLog.0 instutil/chmod instutil/ln CLEANFILES = libtool libtoolize ltconfig.T ltmain.shT # These are required by libtoolize. @@ -101,8 +101,8 @@ configure-subdirs distdir: $(DIST_MAKEFILE_LIST) # Create and install libltdl install-data-hook: + PATH=`cd $(srcdir)/instutil && pwd`":$$PATH" && \ cd libltdl && $(MAKE) distdir distdir=$(DESTDIR)$(pkgdatadir)/libltdl - chmod 755 $(DESTDIR)$(pkgdatadir)/libltdl # Uninstall libltdl uninstall-local: diff --git a/instutil/chmod b/instutil/chmod new file mode 100755 index 000000000..8849f320a --- /dev/null +++ b/instutil/chmod @@ -0,0 +1,13 @@ +#! /bin/sh + +# by Alexandre Oliva + +# Libtool's `make install' uses libltdl's `make dist' to install the +# libltdl source tree. automake will try to create directories with +# mode 777, because the GNU coding standards mandate so, but we don't +# want installed directories with such modes, so we just ignore such +# chmods, and leave it up to the installer's umask to do the right +# thing. + +test x"$1" = x"777" && echo Possibly unsafe chmod ignored >&2 +exit 0 diff --git a/instutil/ln b/instutil/ln new file mode 100755 index 000000000..4b9eb40bc --- /dev/null +++ b/instutil/ln @@ -0,0 +1,14 @@ +#! /bin/sh + +# by Alexandre Oliva + +# Libtool's `make install' uses libltdl's `make dist' to install the +# libltdl source tree. automake will try to create hard-links into +# the source tree by default, to speed things up, but we don't want +# editing the source tree to mess up the installed version, so we'd +# better avoid hard links. Since automake will try `cp' when `ln' +# fails, we just echo the `cp' command automake will run, to tell +# installers what's going on, and then fail. + +echo cp -p ${1+"$@"} +exit 1 diff --git a/mail/security b/mail/security deleted file mode 100644 index 492880efb..000000000 --- a/mail/security +++ /dev/null @@ -1,65 +0,0 @@ -From: Andreas Schwab -Subject: SECURITY ALERT -To: bug-libtool@gnu.org -Date: 05 May 1999 10:27:50 +0200 -X-From-Line: schwab@issan.cs.uni-dortmund.de Sun May 05 10:27:50 1999 -Return-Path: -Received: from punt-1.mail.demon.net by mailstore - for gvaughan@oranda.demon.co.uk id 925892917:10:19057:0; - Wed, 05 May 99 08:28:37 GMT -Received: from mescaline.gnu.org ([158.121.106.21]) by punt-1.mail.demon.net - id aa1018999; 5 May 99 8:28 GMT -Received: (from slist@localhost) - by mescaline.gnu.org (8.9.1a/8.9.1) id EAA03064; - Wed, 5 May 1999 04:28:09 -0400 -Resent-Date: Wed, 5 May 1999 04:28:09 -0400 -Received: from waldorf.cs.uni-dortmund.de ([129.217.4.42]) - by mescaline.gnu.org (8.9.1a/8.9.1) with ESMTP id EAA03048 - for ; Wed, 5 May 1999 04:27:56 -0400 -Received: from issan.cs.uni-dortmund.de (issan.cs.uni-dortmund.de [129.217.27.163]) by waldorf.cs.uni-dortmund.de with SMTP id KAA08469 for ; Wed, 5 May 1999 10:27:51 +0200 (MES) -Received: by issan.cs.uni-dortmund.de id AA16239; Wed, 5 May 99 10:27:50 +0200 -X-Yow: I want to so HAPPY, the VEINS in my neck STAND OUT!! -X-Gnus-Mail-Source: pop:oranda@pop3.mail.demon.net -Message-Id: -Resent-Message-ID: <"1sULG3.0.ml.G40Ct"@mescaline.gnu.org> -Resent-From: bug-libtool@gnu.org -X-Mailing-List: archive/latest/861 -X-Loop: bug-libtool@gnu.org -Precedence: list -Resent-Sender: bug-libtool-request@gnu.org -Lines: 33 -Xref: SAMHAIN mail.bug-libtool:555 - -During installing libtool a WORLD WRITABLE DIRECTORY is created! - - -1999-05-04 Andreas Schwab - - * Makefile.am (install-data-hook): Remove this huge security - breach. - (uninstall-local): Removed. - ---- libtool-1.3/Makefile.am.~1~ Sun Apr 25 21:05:55 1999 -+++ libtool-1.3/Makefile.am Tue May 4 14:11:24 1999 -@@ -99,14 +99,6 @@ - abs_srcdir=`cd $(top_srcdir) && pwd`; \ - (cd $$dir && $$abs_srcdir/$$dir/configure) || exit 1 - --# Create and install libltdl --install-data-hook: -- cd libltdl && $(MAKE) distdir distdir=$(DESTDIR)$(pkgdatadir)/libltdl -- --# Uninstall libltdl --uninstall-local: -- -rm -rf $(DESTDIR)$(pkgdatadir)/libltdl -- - ################################################################ - ## - ## Everything past here is useful to the maintainer, but probably not - --- -Andreas Schwab "And now for something -schwab@issan.cs.uni-dortmund.de completely different" -schwab@gnu.org - - -- 2.47.3