From 5f18797450549e4f67a75ee2b08cd639ae1fa54d Mon Sep 17 00:00:00 2001 From: Martin Jambor Date: Tue, 3 Oct 2023 19:09:33 +0200 Subject: [PATCH] contrib/mklog.py: Fix issues reported by flake8 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The testing infrastructure built by Martin Liška contains checking a few python scripts in contrib witha tool flake8. That tool recently complains that: contrib/mklog.py:360:45: E711 comparison to None should be 'if cond is None:' contrib/mklog.py:362:1: E305 expected 2 blank lines after class or function definition, found 1 I'd like to silence these with the following, hopefully trivial, changes. However, I have only tested the changes by running flake8 again and running ./contrib/mklog.py --help. Is this good for trunk? (Or should I stop using flake8 instead?) Thanks, Martin contrib/ChangeLog: 2023-10-03 Martin Jambor * mklog.py (skip_line_in_changelog): Compare to None using is instead of ==, add an extra newline after the function. --- contrib/mklog.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/mklog.py b/contrib/mklog.py index effe5aa1ca52..1c2c3216e9e1 100755 --- a/contrib/mklog.py +++ b/contrib/mklog.py @@ -357,7 +357,8 @@ def update_copyright(data): def skip_line_in_changelog(line): - return FIRST_LINE_OF_END_RE.match(line) == None + return FIRST_LINE_OF_END_RE.match(line) is None + if __name__ == '__main__': extra_args = os.getenv('GCC_MKLOG_ARGS') -- 2.47.2