From 60453483b5c26447df95a8a80712e809094cb2a2 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Thu, 8 Dec 2022 23:37:32 +0100 Subject: [PATCH] noproxy: guard against empty hostnames in noproxy check When checking for a noproxy setting we need to ensure that we get a hostname passed in. If there is no hostname then there cannot be a matching noproxy rule for it by definition. Closes: #10057 Reported-by: Geeknik Labs Reviewed-by: Daniel Stenberg --- lib/noproxy.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/noproxy.c b/lib/noproxy.c index fb856e4faa..9b13fe8956 100644 --- a/lib/noproxy.c +++ b/lib/noproxy.c @@ -121,6 +121,13 @@ enum nametype { ****************************************************************/ bool Curl_check_noproxy(const char *name, const char *no_proxy) { + /* + * If we don't have a hostname at all, like for example with a FILE + * transfer, we have nothing to interrogate the noproxy list with. + */ + if(!name || name[0] == '\0') + return FALSE; + /* no_proxy=domain1.dom,host.domain2.dom * (a comma-separated list of hosts which should * not be proxied, or an asterisk to override -- 2.47.3