From 607a7dcf2e981449a4b200f497f8ea97ddb5e13f Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 7 Feb 2025 12:16:03 +0300 Subject: [PATCH] RDMA/mana_ib: Fix error code in probe() Return -ENOMEM if dma_pool_create() fails. Don't return success. Fixes: df91c470d9e5 ("RDMA/mana_ib: create/destroy AH") Signed-off-by: Dan Carpenter Link: https://patch.msgid.link/2bbe900e-18b3-46b5-a08c-42eb71886da6@stanley.mountain Reviewed-by: Long Li Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mana/device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c index 640a2c96b5ca0..0c7a9929168f3 100644 --- a/drivers/infiniband/hw/mana/device.c +++ b/drivers/infiniband/hw/mana/device.c @@ -151,8 +151,10 @@ static int mana_ib_probe(struct auxiliary_device *adev, dev->av_pool = dma_pool_create("mana_ib_av", mdev->gdma_context->dev, MANA_AV_BUFFER_SIZE, MANA_AV_BUFFER_SIZE, 0); - if (!dev->av_pool) + if (!dev->av_pool) { + ret = -ENOMEM; goto destroy_rnic; + } ret = ib_register_device(&dev->ib_dev, "mana_%d", mdev->gdma_context->dev); -- 2.47.2