From 613d953988ab944da6be735e3e2b2274cc7de88c Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Mon, 29 Jan 2024 11:07:17 +0900 Subject: [PATCH] varlink: add short comment that the log message is checked in test Follow-up for 038e4554627c610ae6799d74f9f4bce530d7c283. --- src/shared/varlink.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/shared/varlink.c b/src/shared/varlink.c index 1103a145aec..1e1e4d48f97 100644 --- a/src/shared/varlink.c +++ b/src/shared/varlink.c @@ -1439,7 +1439,9 @@ static int varlink_dispatch_method(Varlink *v) { r = varlink_idl_validate_method_call(v->current_method, parameters, &bad_field); if (r < 0) { - varlink_log_errno(v, r, "Parameters for method %s() didn't pass validation on field '%s': %m", method, strna(bad_field)); + /* Please adjust test/units/end.sh when updating the log message. */ + varlink_log_errno(v, r, "Parameters for method %s() didn't pass validation on field '%s': %m", + method, strna(bad_field)); if (IN_SET(v->state, VARLINK_PROCESSING_METHOD, VARLINK_PROCESSING_METHOD_MORE)) { r = varlink_error_invalid_parameter_name(v, bad_field); @@ -2494,7 +2496,9 @@ int varlink_reply(Varlink *v, JsonVariant *parameters) { r = varlink_idl_validate_method_reply(v->current_method, parameters, &bad_field); if (r < 0) - varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m", v->current_method->name, strna(bad_field)); + /* Please adjust test/units/end.sh when updating the log message. */ + varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m", + v->current_method->name, strna(bad_field)); } r = varlink_enqueue_json(v, m); @@ -2571,7 +2575,9 @@ int varlink_error(Varlink *v, const char *error_id, JsonVariant *parameters) { r = varlink_idl_validate_error(symbol, parameters, &bad_field); if (r < 0) - varlink_log_errno(v, r, "Parameters for error %s didn't pass validation on field '%s', ignoring: %m", error_id, strna(bad_field)); + /* Please adjust test/units/end.sh when updating the log message. */ + varlink_log_errno(v, r, "Parameters for error %s didn't pass validation on field '%s', ignoring: %m", + error_id, strna(bad_field)); } r = varlink_enqueue_json(v, m); @@ -2693,7 +2699,9 @@ int varlink_notify(Varlink *v, JsonVariant *parameters) { r = varlink_idl_validate_method_reply(v->current_method, parameters, &bad_field); if (r < 0) - varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m", v->current_method->name, strna(bad_field)); + /* Please adjust test/units/end.sh when updating the log message. */ + varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m", + v->current_method->name, strna(bad_field)); } r = varlink_enqueue_json(v, m); -- 2.47.3