From 6159adbca6e8d42c0a092f6eb73a1b8eadd86973 Mon Sep 17 00:00:00 2001 From: Bob Halley Date: Fri, 17 Dec 2010 13:44:28 -0800 Subject: [PATCH] use is and not == when comparing sections --- ChangeLog | 6 ++++++ dns/message.py | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6a07424d..0fff77f9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2010-12-17 Bob Halley + + * dns/message.py (_WireReader._get_section): use "is" and not "==" + when testing what section an RR is in. Thanks to James Raftery + for reporting this bug. + 2010-12-10 Bob Halley * dns/resolver.py (Resolver.query): disallow metaqueries. diff --git a/dns/message.py b/dns/message.py index 5ec711e1..a124a3e1 100644 --- a/dns/message.py +++ b/dns/message.py @@ -686,7 +686,7 @@ class _WireReader(object): deleting = None if deleting == dns.rdataclass.ANY or \ (deleting == dns.rdataclass.NONE and \ - section == self.message.answer): + section is self.message.answer): covers = dns.rdatatype.NONE rd = None else: -- 2.47.3