From 61f510600e2c7cdee6e61f8b7075fb0e939eb179 Mon Sep 17 00:00:00 2001 From: Peiwei Hu Date: Thu, 23 Jun 2022 23:59:50 +0800 Subject: [PATCH] crypto/provider_core.c: Avoid calling unlock two times Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/18641) --- crypto/provider_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crypto/provider_core.c b/crypto/provider_core.c index 072e29e0237..6f82b298355 100644 --- a/crypto/provider_core.c +++ b/crypto/provider_core.c @@ -641,7 +641,7 @@ int ossl_provider_add_to_store(OSSL_PROVIDER *prov, OSSL_PROVIDER **actualprov, if (!ossl_provider_up_ref(actualtmp)) { ERR_raise(ERR_LIB_CRYPTO, ERR_R_MALLOC_FAILURE); actualtmp = NULL; - goto err; + return 0; } *actualprov = actualtmp; } @@ -665,8 +665,6 @@ int ossl_provider_add_to_store(OSSL_PROVIDER *prov, OSSL_PROVIDER **actualprov, err: CRYPTO_THREAD_unlock(store->lock); - if (actualprov != NULL) - ossl_provider_free(*actualprov); return 0; } -- 2.47.2