From 63bc7ea39c617e0d4cc19fb992b3c0fd6aae8d83 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 13 May 2025 17:12:09 +0200 Subject: [PATCH] qemuBuildCommandLine: Drop 'snapshot' argument After recent refactors that removed legacy way to revert snapshots we no longer need to know the snapshot state during commandline build. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_command.c | 5 ++--- src/qemu/qemu_command.h | 1 - src/qemu/qemu_process.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2f687779cd..08069ffac8 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10483,7 +10483,6 @@ qemuBuildCompatDeprecatedCommandLine(virCommand *cmd, virCommand * qemuBuildCommandLine(virDomainObj *vm, const char *migrateURI, - virDomainMomentObj *snapshot, virNetDevVPortProfileOp vmop, size_t *nnicindexes, int **nicindexes) @@ -10497,8 +10496,8 @@ qemuBuildCommandLine(virDomainObj *vm, virDomainDef *def = vm->def; virQEMUCaps *qemuCaps = priv->qemuCaps; - VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s snapshot=%p vmop=%d", - def->name, def, migrateURI, snapshot, vmop); + VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s vmop=%d", + def->name, def, migrateURI, vmop); if (qemuBuildCommandLineValidate(driver, def) < 0) return NULL; diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index a386c34f20..2d43cf5506 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -43,7 +43,6 @@ VIR_ENUM_DECL(qemuSoundCodec); virCommand * qemuBuildCommandLine(virDomainObj *vm, const char *migrateURI, - virDomainMomentObj *snapshot, virNetDevVPortProfileOp vmop, size_t *nnicindexes, int **nicindexes); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 975358b224..9b191ebd4f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8046,7 +8046,7 @@ qemuProcessLaunch(virConnectPtr conn, if (!(cmd = qemuBuildCommandLine(vm, incoming ? "defer" : NULL, - snapshot, vmop, + vmop, &nnicindexes, &nicindexes))) goto cleanup; @@ -8712,7 +8712,6 @@ qemuProcessCreatePretendCmdBuild(virDomainObj *vm, { return qemuBuildCommandLine(vm, migrateURI, - NULL, VIR_NETDEV_VPORT_PROFILE_OP_NO_OP, NULL, NULL); -- 2.47.2