From 6481b06a197f0bd826ca29b328547ff99a653193 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Fri, 17 Mar 2023 14:18:58 +0100 Subject: [PATCH] virQEMUCapsInitGuestFromBinary: Refactor cleanup MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Remove useless call to virCapabilitiesFreeMachines as the pointers were cleared and the unneeded 'ret' variable. Since we don't need to clear the 'machines' pointer now, remove that as well. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 877b725920..bbb1784a91 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1105,7 +1105,6 @@ virQEMUCapsInitGuestFromBinary(virCaps *caps, virCapsGuest *guest; virCapsGuestMachine **machines = NULL; size_t nmachines = 0; - int ret = -1; if (!binary) return 0; @@ -1118,9 +1117,6 @@ virQEMUCapsInitGuestFromBinary(virCaps *caps, guestarch, binary, NULL, nmachines, machines); - machines = NULL; - nmachines = 0; - /* CPU selection is always available, because all QEMU versions * we support can use at least '-cpu host' */ virCapabilitiesAddGuestFeature(guest, VIR_CAPS_GUEST_FEATURE_TYPE_CPUSELECTION); @@ -1155,11 +1151,7 @@ virQEMUCapsInitGuestFromBinary(virCaps *caps, virCapabilitiesAddGuestFeature(guest, VIR_CAPS_GUEST_FEATURE_TYPE_NONPAE); } - ret = 0; - - virCapabilitiesFreeMachines(machines, nmachines); - - return ret; + return 0; } -- 2.47.2