From 6506939352a2a52071bd56fcf5a8af243ec8e27b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Ga=C3=ABtan=20de=20Menten?= Date: Tue, 17 Jul 2007 09:00:25 +0000 Subject: [PATCH] - fixed max identifier length on postgres (63) [ticket:571] - fixed doc typo ("in_" operator) - misc indent stuff --- CHANGES | 4 +++- doc/build/content/sqlconstruction.txt | 2 +- lib/sqlalchemy/databases/postgres.py | 2 +- lib/sqlalchemy/orm/properties.py | 2 +- lib/sqlalchemy/sql_util.py | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGES b/CHANGES index f54ff078be..81dd74e1ab 100644 --- a/CHANGES +++ b/CHANGES @@ -2,7 +2,9 @@ - sql - got connection-bound metadata to work with implicit execution - cleanup to connection-bound sessions, SessionTransaction - +- postgres + - fixed max identifier length (63) [ticket:571] + 0.3.9 - general - better error message for NoSuchColumnError [ticket:607] diff --git a/doc/build/content/sqlconstruction.txt b/doc/build/content/sqlconstruction.txt index a672fb5cec..2c3a68aea4 100644 --- a/doc/build/content/sqlconstruction.txt +++ b/doc/build/content/sqlconstruction.txt @@ -318,7 +318,7 @@ Select statements can also generate a WHERE clause based on the parameters you g #### Operators {@name=operators} -Supported column operators so far are all the numerical comparison operators, i.e. '==', '>', '>=', etc., as well as `like()`, `startswith()`, `endswith()`, `between()`, and `in()`. Boolean operators include `not_()`, `and_()` and `or_()`, which also can be used inline via '~', '&', and '|'. Math operators are '+', '-', '*', '/'. Any custom operator can be specified via the `op()` function shown below. +Supported column operators so far are all the numerical comparison operators, i.e. '==', '>', '>=', etc., as well as `like()`, `startswith()`, `endswith()`, `between()`, and `in_()`. Boolean operators include `not_()`, `and_()` and `or_()`, which also can be used inline via '~', '&', and '|'. Math operators are '+', '-', '*', '/'. Any custom operator can be specified via the `op()` function shown below. {python} # "like" operator diff --git a/lib/sqlalchemy/databases/postgres.py b/lib/sqlalchemy/databases/postgres.py index 068a4d0a1c..d3726fc1ff 100644 --- a/lib/sqlalchemy/databases/postgres.py +++ b/lib/sqlalchemy/databases/postgres.py @@ -275,7 +275,7 @@ class PGDialect(ansisql.ANSIDialect): return PGExecutionContext(self, *args, **kwargs) def max_identifier_length(self): - return 68 + return 63 def type_descriptor(self, typeobj): if self.version == 2: diff --git a/lib/sqlalchemy/orm/properties.py b/lib/sqlalchemy/orm/properties.py index 6677e4ab94..a00a35ab66 100644 --- a/lib/sqlalchemy/orm/properties.py +++ b/lib/sqlalchemy/orm/properties.py @@ -91,7 +91,7 @@ class PropertyLoader(StrategizedProperty): self.association = association self.order_by = order_by - self.attributeext=attributeext + self.attributeext = attributeext if isinstance(backref, str): # propigate explicitly sent primary/secondary join conditions to the BackRef object if # just a string was sent diff --git a/lib/sqlalchemy/sql_util.py b/lib/sqlalchemy/sql_util.py index debf1da4f9..9235b9c4ec 100644 --- a/lib/sqlalchemy/sql_util.py +++ b/lib/sqlalchemy/sql_util.py @@ -53,7 +53,7 @@ class TableCollection(object): for table in self.tables: vis.traverse(table) sorter = topological.QueueDependencySorter( tuples, self.tables ) - head = sorter.sort() + head = sorter.sort() sequence = [] def to_sequence( node, seq=sequence): seq.append( node.item ) -- 2.47.2