From 650eda72ae6a3533a1a18d6245915f3e61c33f37 Mon Sep 17 00:00:00 2001 From: Geoff Kimball Date: Thu, 11 Feb 2016 09:48:47 -0800 Subject: [PATCH] Fix tabs not initializing and not showing/hiding properly --- js/foundation.tabs.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/js/foundation.tabs.js b/js/foundation.tabs.js index aed68afbc..c7c3b1934 100644 --- a/js/foundation.tabs.js +++ b/js/foundation.tabs.js @@ -48,7 +48,7 @@ export default class Tabs { $link = $elem.find('a'), isActive = $elem.hasClass('is-active'), hash = $link[0].hash.slice(1), - linkId = $link[0].id ? $link[0].id : `hash${-label}`, + linkId = $link[0].id ? $link[0].id : `${hash}-label`, $tabContent = $(`#${hash}`); $elem.attr({'role': 'presentation'}); @@ -176,15 +176,13 @@ export default class Tabs { var $tabLink = $target.find('[role="tab"]'), hash = $tabLink[0].hash, $targetContent = this.$tabContent.find(hash), - $oldTab = this.$element.find(`.${this.options.linkClass}.is-active`); + $oldTab = this.$element. + find(`.${this.options.linkClass}.is-active`) + .removeClass('is-active') + .find('[role="tab"]') + .attr({ 'aria-selected': 'false' }); - $oldTab - .removeClass('is-active') - .find('[role="tab"]') - .attr({ 'aria-selected': 'false' }) - .attr('aria-controls'); - - $(`#${$oldTab}`) + $(`#${$oldTab.attr('aria-controls')}`) .removeClass('is-active') .attr({ 'aria-hidden': 'true' }); -- 2.47.2