From 665567f2c86a5f42b19a9d416a0955b9cc6927a7 Mon Sep 17 00:00:00 2001 From: Shan Date: Sat, 21 Jan 2023 14:07:14 -0800 Subject: [PATCH] new test catches #9133 and lint fix --- lib/sqlalchemy/dialects/mssql/base.py | 1 - test/dialect/mssql/test_compiler.py | 14 -------------- test/dialect/mssql/test_reflection.py | 18 ++++++++++++++++++ 3 files changed, 18 insertions(+), 15 deletions(-) diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py index b8fe8a3710..eabea88db6 100644 --- a/lib/sqlalchemy/dialects/mssql/base.py +++ b/lib/sqlalchemy/dialects/mssql/base.py @@ -2875,7 +2875,6 @@ def _owner_plus_db(dialect, schema): return _schema_elements(schema) - _memoized_schema = util.LRUCache() diff --git a/test/dialect/mssql/test_compiler.py b/test/dialect/mssql/test_compiler.py index b666c3cba9..00bbc2af45 100644 --- a/test/dialect/mssql/test_compiler.py +++ b/test/dialect/mssql/test_compiler.py @@ -599,20 +599,6 @@ class CompileTest(fixtures.TestBase, AssertsCompiledSQL): checkpositional=("bar",), ) - def test_schema_single_token_bracketed(self): - metadata = MetaData() - tbl = Table( - "test", - metadata, - Column("id", Integer, primary_key=True), - schema="[abc]", - ) - - self.assert_compile( - select(tbl), - "SELECT abc.test.id FROM abc.test", - ) - def test_schema_many_tokens_one(self): metadata = MetaData() tbl = Table( diff --git a/test/dialect/mssql/test_reflection.py b/test/dialect/mssql/test_reflection.py index 1716d68e39..2749156f36 100644 --- a/test/dialect/mssql/test_reflection.py +++ b/test/dialect/mssql/test_reflection.py @@ -410,6 +410,24 @@ class ReflectionTest(fixtures.TestBase, ComparesTables, AssertsCompiledSQL): ) Table(tname, MetaData(), autoload_with=conn) + @testing.combinations( + ("test_schema"), + ("[test_schema]"), + argnames="schema_value", + ) + def test_has_table_with_schema_token_comb( + self, metadata, connection, schema_value + ): + tt = Table( + 'test', + metadata, + Column("id", Integer), + schema=schema_value + ) + tt.create(connection) + found_it = inspect(connection).has_table("test", schema=schema_value) + eq_(found_it, True) + def test_db_qualified_items(self, metadata, connection): Table("foo", metadata, Column("id", Integer, primary_key=True)) Table( -- 2.47.3