From 66f2db73116240cb94c93e9ee4b9e5229ef98c22 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 24 Sep 2013 16:12:47 +0100 Subject: [PATCH] Fix leak in virDomainDefParseXML parsing vcpupin If virBitmapNew fails due to OOM, the 'vcpupin' variable is leaked. Signed-off-by: Daniel P. Berrange --- src/conf/domain_conf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cee0c93d26..70fdafc2b1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11194,8 +11194,10 @@ virDomainDefParseXML(xmlDocPtr xml, if (VIR_ALLOC(vcpupin) < 0) goto error; - if (!(vcpupin->cpumask = virBitmapNew(VIR_DOMAIN_CPUMASK_LEN))) + if (!(vcpupin->cpumask = virBitmapNew(VIR_DOMAIN_CPUMASK_LEN))) { + VIR_FREE(vcpupin); goto error; + } virBitmapCopy(vcpupin->cpumask, def->cpumask); vcpupin->vcpuid = i; def->cputune.vcpupin[def->cputune.nvcpupin++] = vcpupin; -- 2.47.2