From 6774a89048c04ac8cdebf7ba694ea913ec949ce9 Mon Sep 17 00:00:00 2001 From: Andrew Donnellan Date: Fri, 5 Jul 2019 13:27:41 +1000 Subject: [PATCH] filters: Escape State names when generating selector HTML States with names containing special characters are not correctly escaped when generating the select list. Use escape() to fix this. Signed-off-by: Andrew Donnellan (cherry picked from commit b3fa0c402e060622a5ed539a465d2fa98b1d2e13) Signed-off-by: Daniel Axtens --- patchwork/filters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/filters.py b/patchwork/filters.py index 2ddeb18d..1358cc0b 100644 --- a/patchwork/filters.py +++ b/patchwork/filters.py @@ -254,7 +254,7 @@ class StateFilter(Filter): selected = ' selected="true"' out += '' % ( - state.id, selected, state.name) + state.id, selected, escape(state.name)) out += '' return mark_safe(out) -- 2.47.3