From 67d50818a7f0f06385d4635bdd96614cb542c5ee Mon Sep 17 00:00:00 2001
From: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Date: Tue, 27 Jun 2023 16:55:18 +0200
Subject: [PATCH] gccrs: collector: Fix some token collector

Some ast subtrees where not correctly collected. Among those where macro
match repetition introducing empty tokens.

gcc/rust/ChangeLog:

	* ast/rust-ast-collector.cc (TokenCollector::visit): Fix several
	token collection rules.
	* ast/rust-ast-dump.cc (Dump::require_spacing): Add spacing rule
	for comma.

Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
---
 gcc/rust/ast/rust-ast-collector.cc | 24 +++++++++++++-----------
 gcc/rust/ast/rust-ast-dump.cc      |  1 +
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/gcc/rust/ast/rust-ast-collector.cc b/gcc/rust/ast/rust-ast-collector.cc
index 38eb31780f95..7bf827e7bb75 100644
--- a/gcc/rust/ast/rust-ast-collector.cc
+++ b/gcc/rust/ast/rust-ast-collector.cc
@@ -452,16 +452,10 @@ TokenCollector::visit (Token &tok)
 void
 TokenCollector::visit (DelimTokenTree &delim_tok_tree)
 {
-  increment_indentation ();
-  newline ();
-  indentation ();
   for (auto &token : delim_tok_tree.to_token_stream ())
     {
       visit (token);
     }
-  decrement_indentation ();
-  newline ();
-  indentation ();
 }
 
 void
@@ -1270,17 +1264,18 @@ TokenCollector::visit (BlockExpr &expr)
   increment_indentation ();
   visit_items_as_lines (expr.get_inner_attrs ());
 
-  visit_items_as_lines (expr.get_statements (),
-			{Rust::Token::make (SEMICOLON, Location ())});
+  visit_items_as_lines (expr.get_statements (), {});
 
   if (expr.has_tail_expr ())
     {
+      indentation ();
       visit (expr.get_tail_expr ());
       comment ("tail expr");
       newline ();
     }
 
   decrement_indentation ();
+  indentation ();
   push (Rust::Token::make (RIGHT_CURLY, expr.get_locus ()));
   newline ();
 }
@@ -2267,7 +2262,10 @@ TokenCollector::visit (MacroMatchRepetition &repetition)
   push (Rust::Token::make (DOLLAR_SIGN, Location ()));
   push (Rust::Token::make (LEFT_PAREN, Location ()));
 
-  visit_items_joined_by_separator (repetition.get_matches (), {});
+  for (auto &match : repetition.get_matches ())
+    {
+      visit (match);
+    }
 
   push (Rust::Token::make (RIGHT_PAREN, Location ()));
 
@@ -2313,7 +2311,6 @@ TokenCollector::visit (MacroRule &rule)
   visit (rule.get_matcher ());
   push (Rust::Token::make (MATCH_ARROW, rule.get_locus ()));
   visit (rule.get_transcriber ().get_token_tree ());
-  push (Rust::Token::make (SEMICOLON, Location ()));
 }
 
 void
@@ -2341,7 +2338,9 @@ TokenCollector::visit (MacroInvocation &invocation)
   push (Rust::Token::make (EXCLAM, Location ()));
   visit (data.get_delim_tok_tree ());
   if (invocation.has_semicolon ())
-    push (Rust::Token::make (SEMICOLON, Location ()));
+    {
+      push (Rust::Token::make (SEMICOLON, Location ()));
+    }
 }
 
 void
@@ -2693,12 +2692,15 @@ TokenCollector::visit (LetStmt &stmt)
       push (Rust::Token::make (EQUAL, Location ()));
       visit (stmt.get_init_expr ());
     }
+  push (Rust::Token::make (SEMICOLON, Location ()));
 }
 
 void
 TokenCollector::visit (ExprStmt &stmt)
 {
   visit (stmt.get_expr ());
+  if (stmt.is_semicolon_followed ())
+    push (Rust::Token::make (SEMICOLON, Location ()));
 }
 
 // rust-type.h
diff --git a/gcc/rust/ast/rust-ast-dump.cc b/gcc/rust/ast/rust-ast-dump.cc
index e8a3c08834c0..ba8b0badfafd 100644
--- a/gcc/rust/ast/rust-ast-dump.cc
+++ b/gcc/rust/ast/rust-ast-dump.cc
@@ -45,6 +45,7 @@ Dump::require_spacing (TokenPtr previous, TokenPtr current)
     case RIGHT_PAREN:
     case DOLLAR_SIGN:
     case SEMICOLON:
+    case COMMA:
       return false;
     default:
       break;
-- 
2.47.2