From 6801ae8273ffcf781223246dd038a78f71c19e95 Mon Sep 17 00:00:00 2001 From: Andrea Claudi Date: Wed, 14 Apr 2021 00:50:20 +0200 Subject: [PATCH] q_cake: remove useless check on argv In cake_parse_opt(), *argv is checked not to be null when parsing for overhead and mpu parameters. However this is useless, since *argv matches right before for "overhead" or "mpu". Signed-off-by: Andrea Claudi Signed-off-by: Stephen Hemminger --- tc/q_cake.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tc/q_cake.c b/tc/q_cake.c index 4ff6056a1..4cfc1c002 100644 --- a/tc/q_cake.c +++ b/tc/q_cake.c @@ -299,8 +299,7 @@ static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv, NEXT_ARG(); overhead = strtol(*argv, &p, 10); - if (!p || *p || !*argv || - overhead < -64 || overhead > 256) { + if (!p || *p || overhead < -64 || overhead > 256) { fprintf(stderr, "Illegal \"overhead\", valid range is -64 to 256\\n"); return -1; @@ -312,7 +311,7 @@ static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv, NEXT_ARG(); mpu = strtol(*argv, &p, 10); - if (!p || *p || !*argv || mpu < 0 || mpu > 256) { + if (!p || *p || mpu < 0 || mpu > 256) { fprintf(stderr, "Illegal \"mpu\", valid range is 0 to 256\\n"); return -1; -- 2.47.2