From 6833b3d16b43e69bdb23e9c45ad64149d6079f6e Mon Sep 17 00:00:00 2001 From: Razvan Becheriu Date: Thu, 20 Aug 2020 23:07:52 +0300 Subject: [PATCH] [#505] addressed review --- src/lib/dhcpsrv/parsers/base_network_parser.cc | 3 ++- src/lib/dhcpsrv/parsers/dhcp_parsers.cc | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/lib/dhcpsrv/parsers/base_network_parser.cc b/src/lib/dhcpsrv/parsers/base_network_parser.cc index 4bcd178890..00cbc5859e 100644 --- a/src/lib/dhcpsrv/parsers/base_network_parser.cc +++ b/src/lib/dhcpsrv/parsers/base_network_parser.cc @@ -125,7 +125,8 @@ BaseNetworkParser::parseCommon(const ConstElementPtr& network_data, if (has_renew && has_rebind && (renew > rebind)) { isc_throw(DhcpConfigError, "the value of renew-timer" << " (" << renew - << ") is greater than rebind-timer" << " (" << rebind << ")"); + << ") is greater than the value of rebind-timer" << " (" + << rebind << ")"); } network->setValid(parseLifetime(network_data, "valid-lifetime")); diff --git a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc index 9f339d69b4..ee4ba53497 100644 --- a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc +++ b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc @@ -767,7 +767,8 @@ Subnet4ConfigParser::initSubnet(data::ConstElementPtr params, if (has_renew && has_rebind && (renew > rebind)) { isc_throw(DhcpConfigError, "the value of renew-timer" << " (" << renew - << ") is greater than rebind-timer" << " (" << rebind << ")"); + << ") is greater than the value of rebind-timer" << " (" + << rebind << ")"); } if (!subnet4->getValid().unspecified()) { @@ -1262,7 +1263,8 @@ Subnet6ConfigParser::initSubnet(data::ConstElementPtr params, if (has_renew && has_rebind && (renew > rebind)) { isc_throw(DhcpConfigError, "the value of renew-timer" << " (" << renew - << ") is greater than rebind-timer" << " (" << rebind << ")"); + << ") is greater than the value of rebind-timer" << " (" + << rebind << ")"); } if (!subnet6->getPreferred().unspecified()) { -- 2.47.2