From 688efe79f0975d98157ae9502c99c8c1172e5fe3 Mon Sep 17 00:00:00 2001
From: Philippe Antoine <contact@catenacyber.fr>
Date: Mon, 5 Jun 2023 08:43:05 +0200
Subject: [PATCH] output/dns: do not add empty app-layer metadata

---
 src/output-json-dns.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/output-json-dns.c b/src/output-json-dns.c
index 3c7009b501..9cab2bde55 100644
--- a/src/output-json-dns.c
+++ b/src/output-json-dns.c
@@ -293,19 +293,22 @@ static JsonBuilder *JsonDNSLogAnswer(void *txptr)
 
 bool AlertJsonDns(void *txptr, JsonBuilder *js)
 {
+    bool r = false;
     jb_open_object(js, "dns");
     JsonBuilder *qjs = JsonDNSLogQuery(txptr);
     if (qjs != NULL) {
         jb_set_object(js, "query", qjs);
         jb_free(qjs);
+        r = true;
     }
     JsonBuilder *ajs = JsonDNSLogAnswer(txptr);
     if (ajs != NULL) {
         jb_set_object(js, "answer", ajs);
         jb_free(ajs);
+        r = true;
     }
     jb_close(js);
-    return true;
+    return r;
 }
 
 static int JsonDnsLoggerToServer(ThreadVars *tv, void *thread_data,
-- 
2.47.2