From 68c703872cf4816d6ea0f54745fa9516616a85f3 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Tue, 27 May 2025 16:55:43 +0200 Subject: [PATCH] string-table: drop unneeded initialization --- src/basic/string-table.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/basic/string-table.c b/src/basic/string-table.c index fa3cc15743d..069cb40ec1a 100644 --- a/src/basic/string-table.c +++ b/src/basic/string-table.c @@ -42,6 +42,7 @@ int string_table_lookup_to_string_fallback(const char * const *table, size_t len if (i < 0 || i > (ssize_t) max) return -ERANGE; + if (i < (ssize_t) len && table[i]) { s = strdup(table[i]); if (!s) @@ -54,14 +55,14 @@ int string_table_lookup_to_string_fallback(const char * const *table, size_t len } ssize_t string_table_lookup_from_string_fallback(const char * const *table, size_t len, const char *s, size_t max) { - unsigned u = 0; - if (!s) return -EINVAL; ssize_t i = string_table_lookup_from_string(table, len, s); if (i >= 0) return i; + + unsigned u; if (safe_atou(s, &u) < 0) return -EINVAL; if (u > max) -- 2.47.3