From 69b1c4026ccea8f653d3f7908dcdbf85ff75da98 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 18 Apr 1999 15:57:19 +0000 Subject: [PATCH] (tempname): Add a FIXME comment. --- src/sort.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/sort.c b/src/sort.c index d69cb4f050..5918b6a6fc 100644 --- a/src/sort.c +++ b/src/sort.c @@ -450,10 +450,15 @@ tempname (void) (len && temp_dir[len - 1] != '/') ? "/" : "", (unsigned int) getpid () & 0xffff, seq); else - sprintf (name, "%s%ss%5.5d%2.2d.%3.3d", - temp_dir, - (len && temp_dir[len - 1] != '/') ? "/" : "", - (unsigned int) getpid () & 0xffff, seq / 1000, seq % 1000); + { + sprintf (name, "%s%ss%5.5d%2.2d.%3.3d", + temp_dir, + (len && temp_dir[len - 1] != '/') ? "/" : "", + (unsigned int) getpid () & 0xffff, seq / 1000, seq % 1000); + + /* FIXME: fail if seq exceeds 99999 -- at which point sort + would start reusing temporary file names. */ + } /* Make sure that SEQ's value fits in 5 digits. */ ++seq; -- 2.47.3