From 6a8a25dc7de69c4c6907438222c8fcb1854c35e9 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Wed, 15 Oct 2025 18:01:14 +0200 Subject: [PATCH] src/usermod.c: Remove optimizations These optimizations checked if the old value is the same as the new value, and skip such changes. This was unnecessary, and added complexity to the source code. Signed-off-by: Alejandro Colomar --- src/usermod.c | 42 ------------------------------------------ 1 file changed, 42 deletions(-) diff --git a/src/usermod.c b/src/usermod.c index a3b89a5cb..992e56dbb 100644 --- a/src/usermod.c +++ b/src/usermod.c @@ -1379,48 +1379,6 @@ process_flags(int argc, char **argv) } #endif /* WITH_SELINUX */ - if (user_newid == user_id) { - uflg = false; - oflg = false; - } - if (user_newgid == user_gid) { - gflg = false; - } - if ( (NULL != user_newshell) - && streq(user_newshell, user_shell)) { - sflg = false; - } - if (streq(user_newname, user_name)) { - lflg = false; - } - if (user_newinactive == user_inactive) { - fflg = false; - } - if (user_newexpire == user_expire) { - eflg = false; - } - if ( (NULL != user_newhome) - && streq(user_newhome, user_home)) { - dflg = false; - mflg = false; - } - if ( (NULL != user_newcomment) - && streq(user_newcomment, user_comment)) { - cflg = false; - } - - if (!(Uflg || uflg || sflg || pflg || mflg || Lflg || - lflg || Gflg || gflg || fflg || eflg || dflg || cflg -#ifdef ENABLE_SUBIDS - || vflg || Vflg || wflg || Wflg -#endif /* ENABLE_SUBIDS */ -#ifdef WITH_SELINUX - || Zflg -#endif /* WITH_SELINUX */ - )) { - exit (E_SUCCESS); - } - if (!is_shadow_pwd && (eflg || fflg)) { fprintf (stderr, _("%s: shadow passwords required for -e and -f\n"), -- 2.47.3