From 6b1b6cbf093d7d2f38c7f41cda4daadeddbe4cf1 Mon Sep 17 00:00:00 2001 From: Brian Harring Date: Mon, 19 Apr 2010 01:24:01 -0400 Subject: [PATCH] this could stand review, but should be right; setting ret to ARCHIVE_FAILED here is a pointless no op so archive_format_gnutar_header assignment shortly after wipes the ret... potentially this should be set to a warn and then combined w/ the other returns SVN-Revision: 2268 --- libarchive/archive_write_set_format_gnutar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libarchive/archive_write_set_format_gnutar.c b/libarchive/archive_write_set_format_gnutar.c index 3bcf60d13..ae15a4063 100644 --- a/libarchive/archive_write_set_format_gnutar.c +++ b/libarchive/archive_write_set_format_gnutar.c @@ -342,7 +342,7 @@ archive_write_gnutar_header(struct archive_write *a, struct archive_entry *entry ARCHIVE_ERRNO_FILE_FORMAT, "tar format cannot archive this (mode=0%lo)", (unsigned long)archive_entry_mode(entry)); - ret = ARCHIVE_FAILED; + return (ARCHIVE_FAILED); } ret = archive_format_gnutar_header(a, buff, entry, tartype); -- 2.47.3