From 6c1b15768cade72bd7e4595e712dd8776eea0ca1 Mon Sep 17 00:00:00 2001 From: Stefan Eissing Date: Thu, 3 Oct 2024 11:10:29 +0200 Subject: [PATCH] pytest: improve pytest_07_42a reliability Due to timings on paused response receive, the error code may vary due to the location where it is detected that the server closed the transfer prematurely. Be more lenient in always allowing PARTIAL_FILE as ok. Closes #15138 --- tests/http/test_07_upload.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/http/test_07_upload.py b/tests/http/test_07_upload.py index 21f18b3ebb..6dbe0c55da 100644 --- a/tests/http/test_07_upload.py +++ b/tests/http/test_07_upload.py @@ -544,12 +544,14 @@ class TestUpload: pytest.skip(f'example client not built: {client.name}') url = f'https://{env.authority_for(env.domain1, proto)}/curltest/echo?id=[0-0]&die_after=0' r = client.run(['-V', proto, url]) - exp_code = 18 # PARTIAL_FILE - if proto == 'h2': - exp_code = 92 # CURLE_HTTP2_STREAM + if r.exit_code == 18: # PARTIAL_FILE is always ok + pass + elif proto == 'h2': + r.check_exit_code(92) # CURLE_HTTP2_STREAM also ok elif proto == 'h3': - exp_code = 95 # CURLE_HTTP3 - r.check_exit_code(exp_code) + r.check_exit_code(95) # CURLE_HTTP3 also ok + else: + r.check_exit_code(18) # will fail as it should # upload data, pause, let connection die without any response at all @pytest.mark.parametrize("proto", ['http/1.1', 'h2', 'h3']) -- 2.47.3