From 6c39b4dc4766594c6517043af59aeea53ea009d0 Mon Sep 17 00:00:00 2001 From: Antonio Quartulli Date: Sat, 9 Nov 2019 17:37:14 +0100 Subject: [PATCH] socks: use the right function when printing struct openvpn_sockaddr 57623b4e introduced a print_sockaddr() call in socks.c to print an openvpn_sockaddr object. However, this is not correct because print_sockaddr() expects a sockaddr object as argument instead of openvpn_sockaddr. This error did not lead to any issue because the two objects are very similar in regards to the data accessed by print_sockaddr(). Fix this by replacing print_sockaddr() with print_openvpn_sockaddr(). Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20191109163714.25506-1-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19073.html Signed-off-by: Gert Doering --- src/openvpn/socks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c index ad3a70b29..57f0cee23 100644 --- a/src/openvpn/socks.c +++ b/src/openvpn/socks.c @@ -416,7 +416,7 @@ recv_socks_reply(socket_descriptor_t sd, memcpy(&addr->addr.in4.sin_port, buf + 8, sizeof(addr->addr.in4.sin_port)); struct gc_arena gc = gc_new(); msg(M_INFO, "SOCKS proxy wants us to send UDP to %s", - print_sockaddr(addr, &gc)); + print_openvpn_sockaddr(addr, &gc)); gc_free(&gc); } -- 2.47.2