From 6c3da17d1f333f6bd4c07d11e2e304159d550822 Mon Sep 17 00:00:00 2001 From: An Long Date: Thu, 25 Jun 2026 01:26:34 +0900 Subject: [PATCH] Re-raise unexpected exceptions instead of swallowing them in various tests (#152019) Co-authored-by: Stan Ulbrych --- Lib/test/test_fcntl.py | 1 + Lib/test/test_launcher.py | 1 + Lib/test/test_pathlib/test_pathlib.py | 1 + Lib/test/test_socket.py | 2 ++ 4 files changed, 5 insertions(+) diff --git a/Lib/test/test_fcntl.py b/Lib/test/test_fcntl.py index 222b69a6d250..f20a9d407670 100644 --- a/Lib/test/test_fcntl.py +++ b/Lib/test/test_fcntl.py @@ -151,6 +151,7 @@ class TestFcntl(unittest.TestCase): except OSError as exc: if exc.errno == errno.EINVAL: self.skipTest("F_NOTIFY not available by this environment") + raise fcntl.fcntl(fd, cmd, flags) finally: os.close(fd) diff --git a/Lib/test/test_launcher.py b/Lib/test/test_launcher.py index c522bc1c2c09..795890bd7e4b 100644 --- a/Lib/test/test_launcher.py +++ b/Lib/test/test_launcher.py @@ -469,6 +469,7 @@ class TestLauncher(unittest.TestCase, RunPyMixin): except subprocess.CalledProcessError: if not is_installed("2.7"): raise unittest.SkipTest("requires at least one Python 2.x install") + raise self.assertEqual("PythonCore", data["env.company"]) self.assertStartsWith(data["env.tag"], "2.") diff --git a/Lib/test/test_pathlib/test_pathlib.py b/Lib/test/test_pathlib/test_pathlib.py index 2cb4876f5c64..aff66c8efedb 100644 --- a/Lib/test/test_pathlib/test_pathlib.py +++ b/Lib/test/test_pathlib/test_pathlib.py @@ -2870,6 +2870,7 @@ class PathTest(PurePathTest): if (isinstance(e, PermissionError) or "AF_UNIX path too long" in str(e)): self.skipTest("cannot bind Unix socket: " + str(e)) + raise self.assertTrue(P.is_socket()) self.assertFalse(P.is_fifo()) self.assertFalse(P.is_file()) diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py index 63c465e3bfea..542d97e3f886 100644 --- a/Lib/test/test_socket.py +++ b/Lib/test/test_socket.py @@ -1427,6 +1427,7 @@ class GeneralModuleTests(unittest.TestCase): except OSError as e: if e.winerror == 10022: self.skipTest('IPv6 might not be supported') + raise f = lambda a: inet_pton(AF_INET6, a) assertInvalid = lambda a: self.assertRaises( @@ -1517,6 +1518,7 @@ class GeneralModuleTests(unittest.TestCase): except OSError as e: if e.winerror == 10022: self.skipTest('IPv6 might not be supported') + raise f = lambda a: inet_ntop(AF_INET6, a) assertInvalid = lambda a: self.assertRaises( -- 2.47.3