From 6d897fc671063b3038e32ec1eab6ae32a3642b2b Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Wed, 2 Nov 2011 11:53:33 -0600 Subject: [PATCH] test: drop redundant check libvirt.c guarantees that nparams is non-zero for scheduler parameters. * src/test/test_driver.c (testDomainGetSchedulerParamsFlags): Drop redundant check. Avoid strcpy. --- src/test/test_driver.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4e1973adb6..3dbce18376 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2709,11 +2709,12 @@ testDomainGetSchedulerParamsFlags(virDomainPtr domain, goto cleanup; } - if (*nparams < 1) { - testError(VIR_ERR_INVALID_ARG, "%s", _("Invalid parameter count")); + if (virStrcpyStatic(params[0].field, + VIR_DOMAIN_SCHEDULER_WEIGHT) == NULL) { + testError(VIR_ERR_INTERNAL_ERROR, _("Field name '%s' too long"), + VIR_DOMAIN_SCHEDULER_WEIGHT); goto cleanup; } - strcpy(params[0].field, VIR_DOMAIN_SCHEDULER_WEIGHT); params[0].type = VIR_TYPED_PARAM_UINT; /* XXX */ /*params[0].value.ui = privdom->weight;*/ -- 2.47.2