From 6dd413b77311320195f66720554a1f9e5da56830 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Fri, 22 Aug 2025 14:38:03 +0200 Subject: [PATCH] dnsdist: Apply Miod's suggestion Co-authored-by: Miod Vallat Signed-off-by: Remi Gacogne (cherry picked from commit 0cf2668a8c625f72944f682010befbe3089b9dd0) --- pdns/dnsdistdist/dnsdist-nghttp2-in.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pdns/dnsdistdist/dnsdist-nghttp2-in.cc b/pdns/dnsdistdist/dnsdist-nghttp2-in.cc index 16908cd31d..3b4ce122e6 100644 --- a/pdns/dnsdistdist/dnsdist-nghttp2-in.cc +++ b/pdns/dnsdistdist/dnsdist-nghttp2-in.cc @@ -554,7 +554,7 @@ static const std::string s_xForwardedForHeaderName("x-forwarded-for"); static void addHeader(std::vector& headers, const std::string_view& name, bool nameIsStatic, const std::string_view& value, bool valueIsStatic) { - /* Be careful when setting NGHTTP2_NV_FLAG_NO_COPY_NAME or NGHTTP2_NV_FLAG_NO_COPY_VALUE, the corresponding name or value needs to exist until after nghttp2_session_send() has been called, not just nghttp2_submit_response */ + /* Be careful when setting NGHTTP2_NV_FLAG_NO_COPY_NAME or NGHTTP2_NV_FLAG_NO_COPY_VALUE, the corresponding name or value needs to exist until after nghttp2_session_send() has been called, not just nghttp2_submit_response(). */ uint8_t flag{NGHTTP2_NV_FLAG_NONE}; if (nameIsStatic) { flag |= NGHTTP2_NV_FLAG_NO_COPY_NAME; -- 2.47.3